-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record TrialNames group by stages in ExperimentStatus #1023
record TrialNames group by stages in ExperimentStatus #1023
Conversation
Hi @sperlingxx. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR. Not sure if we should do it, personally. Prefer to keep v1alpha3 API stable. I think we can add these new fields and keep the existing fields too. |
/ok-to-test @sperlingxx BTW, could you please add your infomation to https://github.com/kubeflow/katib/blob/master/docs/community/adopters.md if you are evaluating katib? Thanks |
It's done, please check this PR. |
I also agree to keep v1alpha3 API stable, and I will restore count fields. |
Should we wait and move this to next api version(possible beta) bundled with other changes? Related #906 |
@johnugeorge I think we can merge it since it does not break v1alpha3 API. If we have a breaking change in API, we should discuss it before we implement it in the new API. |
SGTM |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
} else if trial.IsFailed() { | ||
trialsFailed++ | ||
sts.KilledTrialList = append(sts.KilledTrialList, trial.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be sts.FailedTrialList
instead of sts.KilledTrialList
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyvelich Yes, I've already fixed it.
Thanks. |
What this PR does / why we need it:
In this PR, several list fields are added to record TrialNames in different stages owned by current Experiment, which facilitates trials tracking. Count fields are removed since trial counts of each stage can be figured out by the length of TrialNames.
This change is