Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record TrialNames group by stages in ExperimentStatus #1023

Merged
merged 5 commits into from
Jan 22, 2020
Merged

record TrialNames group by stages in ExperimentStatus #1023

merged 5 commits into from
Jan 22, 2020

Conversation

sperlingxx
Copy link
Member

@sperlingxx sperlingxx commented Jan 20, 2020

What this PR does / why we need it:
In this PR, several list fields are added to record TrialNames in different stages owned by current Experiment, which facilitates trials tracking. Count fields are removed since trial counts of each stage can be figured out by the length of TrialNames.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @sperlingxx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege
Copy link
Member

gaocegege commented Jan 20, 2020

Thanks for the PR. Not sure if we should do it, personally. Prefer to keep v1alpha3 API stable. I think we can add these new fields and keep the existing fields too.

WDYT @johnugeorge @hougangliu @richardsliu

@gaocegege
Copy link
Member

/ok-to-test

@sperlingxx BTW, could you please add your infomation to https://github.com/kubeflow/katib/blob/master/docs/community/adopters.md if you are evaluating katib? Thanks

@sperlingxx
Copy link
Member Author

/ok-to-test

@sperlingxx BTW, could you please add your infomation to https://github.com/kubeflow/katib/blob/master/docs/community/adopters.md if you are evaluating katib? Thanks

It's done, please check this PR.

@sperlingxx
Copy link
Member Author

Thanks for the PR. Not sure if we should do it, personally. Perfer to keep v1alpha3 API stable. I think we can add these new fields and keep the existing fields too.

WDYT @johnugeorge @hougangliu @richardsliu

I also agree to keep v1alpha3 API stable, and I will restore count fields.

@johnugeorge
Copy link
Member

Should we wait and move this to next api version(possible beta) bundled with other changes?

Related #906

@gaocegege
Copy link
Member

gaocegege commented Jan 21, 2020

@johnugeorge I think we can merge it since it does not break v1alpha3 API.

If we have a breaking change in API, we should discuss it before we implement it in the new API.

WDYT @hougangliu @sperlingxx @johnugeorge

@hougangliu
Copy link
Member

@johnugeorge I think we can merge it since it does not break v1alpha3 API.

If we have a breaking change in API, we should discuss it before we implement it in the new API.

WDYT @hougangliu @sperlingxx @johnugeorge

SGTM

@johnugeorge
Copy link
Member

/lgtm

@hougangliu
Copy link
Member

/approve
thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

} else if trial.IsFailed() {
trialsFailed++
sts.KilledTrialList = append(sts.KilledTrialList, trial.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be sts.FailedTrialList instead of sts.KilledTrialList ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Yes, I've already fixed it.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 22, 2020
@andreyvelich
Copy link
Member

Thanks.
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants