Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary dot product with equal length slice #22

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

kemingy
Copy link
Owner

@kemingy kemingy commented Feb 13, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings February 13, 2025 13:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • build.envd: Language not supported
Comments suppressed due to low confidence (2)

python/tests/test_kmeans.py:15

  • [nitpick] The variable name i is ambiguous. It should be renamed to iteration.
for i in range(100):

src/simd.rs:542

  • Ensure that the removed SIMD functionality is covered by tests.
pub fn binary_dot_product(lhs: &[u64], rhs: &[u64]) -> u32 {
Signed-off-by: Keming <[email protected]>
@kemingy kemingy enabled auto-merge (squash) February 13, 2025 14:28
@kemingy kemingy merged commit 9604626 into main Feb 13, 2025
6 checks passed
@kemingy kemingy deleted the binary_ip_fix branch February 13, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant