Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

CC | ci | stop testing with the forked containerd #5778

Closed
stevenhorsman opened this issue Oct 2, 2023 · 1 comment · Fixed by #5775
Closed

CC | ci | stop testing with the forked containerd #5778

stevenhorsman opened this issue Oct 2, 2023 · 1 comment · Fixed by #5775
Assignees

Comments

@stevenhorsman
Copy link
Member

Now with kata-containers/kata-containers#7676 (amongst others) we have the ability to pull images on the guest without a fork of containerd, we should switch over our testing to use this new method instead

stevenhorsman pushed a commit to fidencio/kata-tests that referenced this issue Oct 2, 2023
And let's test with the image offload to the guest instead.

Fixes: kata-containers#5778

Signed-off-by: Fabiano Fidêncio <[email protected]>
stevenhorsman added a commit to fidencio/kata-tests that referenced this issue Oct 2, 2023
- Update the messages that we check for on failures.
Now we will fail on the host side in nydus-snapshotter
before we hit the credential failures in image-rs,
so update the error check for this new message

Fixes: kata-containers#5778
Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit to fidencio/kata-tests that referenced this issue Oct 2, 2023
- Update the messages that we check for on failures.
Now we will fail on the host side in nydus-snapshotter
before we hit the credential failures in image-rs,
so update the error check for this new message

Fixes: kata-containers#5778
Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit to fidencio/kata-tests that referenced this issue Oct 2, 2023
- Update the messages that we check for on failures.
Now we will fail on the host side in nydus-snapshotter
before we hit the credential failures in image-rs,
so update the error check for this new message

Fixes: kata-containers#5778
Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman added a commit to fidencio/kata-tests that referenced this issue Oct 2, 2023
- Update the messages that we check for on failures.
Now we will fail on the host side in nydus-snapshotter
before we hit the credential failures in image-rs,
so update the error check for this new message

Fixes: kata-containers#5778
Signed-off-by: stevenhorsman <[email protected]>
@stevenhorsman stevenhorsman linked a pull request Oct 17, 2023 that will close this issue
@stevenhorsman
Copy link
Member Author

Closed with #5775 merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants