Flake8 validation

[Neamar]

Although the provided pep8 linter works fine, it lacks some useful datas (especially unused imports). Those datas (and a few others) can be provided with Flake8.

I don't think it would be hard to implement (a clone from pep8 linter, replacing the xargs call with flake8), but it would definitely be useful.

[scottjab]

I will tackle this guy this weekend.

[scottjab]

I just pushed the first version of the module, I haven't tested all the cases yet, but here you go.
https://github.com/scottjab/imhotep_flake8

[Neamar]

Thank you ! I'll test that next week.
On Mar 15, 2014 1:20 PM, "James Scott" [email protected] wrote:

I just pushed the first version of the module, I haven't tested all the
cases yet, but here you go.
https://github.com/scottjab/imhotep_flake8

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-37736825
.

[glogiotatidis]

This is also https://pypi.python.org/pypi/imhotep_flake8/ :)

[scottjab]

@glogiotatidis When I get some time this week I will open a PR to your project, that includes both passing configs inspected from repos, and only linting the files that changed.

[Neamar]

I have some trouble with this...
Flake8 is installed on my system, however i get an error:

(.v_env)┌[neamar@neamar-laptop] [ 8:14] [master ⚡]
└[~/Documents/app/imhotep]> python imhotep/main.py
--repo_name="Neamar/corporate" --github-username="neamar"
--github-password="<hidden>" --pr-number=48
No handlers could be found for logger "__main__"
remote: Counting objects: 7109, done.
remote: Compressing objects: 100% (2228/2228), done.
remote: Total 7109 (delta 4871), reused 7053 (delta 4825)
Receiving objects: 100% (7109/7109), 1.94 MiB | 525.00 KiB/s, done.
Resolving deltas: 100% (4871/4871), done.
Note: checking out '12028bae71542f0d5ed27b525ff89572caaefc9d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 12028ba... Merge branch 'master' into rules
Usage: flake8 [options] input ...

flake8: error: input not specified

When using it on other PR (Neamar/corporate#53 for instance) i get no
errors, but nothing is posted (although the code contains linting errors)

[glogiotatidis]

I meant "There is also.."

@scottjab thnx!