Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0 & nixpkgs release #204

Open
1 of 6 tasks
srid opened this issue Aug 6, 2024 · 8 comments
Open
1 of 6 tasks

1.0 & nixpkgs release #204

srid opened this issue Aug 6, 2024 · 8 comments
Milestone
`omnix-cli` MVP

Comments

@srid
Copy link
Member

srid commented Aug 6, 2024 •
edited
Loading

Before release

See sub-issues below for pending work.

Upstream

  • @srid Release to crates.io Release 1.0 #423
  • Upstream pkgs.omnix to nixpkgs
    • Check: it installs the om binary (not omnix-cli).
    • Check: auto completion works on zsh (macOS) and bash (Linux)
    • Check: it builds on Intel mac
      • Even if upstream doesn't test x86_64-darwin in CI, we should manually make sure that our PR builds.
    • Check: om ci run --on ssh://... works.
@srid srid mentioned this issue Aug 7, 2024
Closed
@srid srid pinned this issue Aug 7, 2024
@srid

This comment was marked as outdated.

Sign in to view
@srid srid unpinned this issue Aug 12, 2024
@srid

This comment was marked as outdated.

Sign in to view
This was referenced Sep 21, 2024
Open
Merged
@srid srid pinned this issue Oct 7, 2024
@srid
Copy link
Member Author

srid commented Dec 4, 2024

Regarding release version of omnixrc:

The caller can now override the omnix invocation as of d25eab3

Once we release 1.0 to nixpkgs, we can host the stable omnixrc at https://ominx.page/omnixrc/1.0 (or some such versioned URL), which file would use nix run nixpkgs/<commithash>#omnix to fetch the pinned omnix.

When we release 1.1, we repeat the same process, allowing existings projects on 1.0 to remain unimpacted until they explicitly upgrade to 1.0 (by changing the URL and hash in their .envrc).

@srid srid modified the milestones: v2, `omnix-cli` MVP Jan 7, 2025
@srid srid changed the title Upstream to nixpkgs 1.0 & upstream to nixpkgs Jan 19, 2025
@srid srid changed the title 1.0 & upstream to nixpkgs 1.0 & nixpkgs release Jan 19, 2025
@shivaraj-bh
Copy link
Member

NixOS/nixpkgs#385761

requires #427

@srid
Copy link
Member Author

srid commented Feb 28, 2025

Is there something we can do in the omnix source tree to avoid having to duplicate this in nixpkgs?

Perhaps a .json file that refers to these inputs, which the Nix expression can use directly.

Image

@srid
Copy link
Member Author

srid commented Feb 28, 2025

This is interesting. I wonder if we can revert the doCheck = false; with this ...

Image

@shivaraj-bh shivaraj-bh mentioned this issue Mar 4, 2025
Merged
@srid
Copy link
Member Author

srid commented Mar 4, 2025

Should I tag after merging #430 - or do we need anything else for nixpkgs upstreaming? Let me know.

srid pushed a commit that referenced this issue Mar 4, 2025
@shivaraj-bh
chore: Define ENVs in a single nix file (#430)
d1fc602 
Avoids the need to explicitly define—and later maintain—these ENVs in
nixpkgs while packaging for #204.

requires juspay/rust-flake#33
@shivaraj-bh
Copy link
Member

shivaraj-bh commented Mar 5, 2025 •
edited
Loading

Should I tag after merging #430 - or do we need anything else for nixpkgs upstreaming? Let me know.

Have to enable checks. I will raise a PR for that.

Edit: #432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
`omnix-cli` MVP
Development

No branches or pull requests
2 participants
@srid @shivaraj-bh