Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment_link): add status page for payment link #3213

Merged
merged 108 commits into from
Jan 10, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Dec 28, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add status page for Payment link, along with PayNow custom button

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Do a Create payment call

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_sVQIn2jtpY15yEiiAMsL7Jlk48uOVAHV7QpZuRV0pdmfYiqwpvzvdIm6Miv1WTEz' \
--data-raw '{
    "amount": 710,
    "currency": "USD",
    "confirm": false,
    "customer_id": "sahkal",
    "return_url": "https://google.com",
    
    "description": "For selling Tea",
    "order_details": [
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 110,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        },
        {
            "product_name": "handling fee",
            "quantity": 1,
            "amount": 100,
            "product_img_link": null
        },
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 100,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        },
        {
            "product_name": "handling fee",
            "quantity": 1,
            "amount": 100,
            "product_img_link": null
        },
        {
            "product_name": "handling fee",
            "quantity": 1,
            "amount": 100,
            "product_img_link": null
        },
        {
            "product_name": "handling fee",
            "quantity": 1,
            "amount": 100,
            "product_img_link": null
        },
        {
            "product_name": "handling fee",
            "quantity": 1,
            "amount": 100,
            "product_img_link": null
        }
    ],    
    "email": "[email protected]", 
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "125.0.0.1"
    },
      "payment_link": true,
    "payment_link_config": {
        "logo" : "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
        "seller_name": "bernard",
        "sdk_layout": "spaced_accordion"
    }
}'

Open payment link and do a successful Payment, Once payment gets a status. Try to open the same payment link again should result in 404 not found page

Screenshot 2024-01-09 at 6 21 30 PM Screenshot 2024-01-09 at 6 23 06 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

sahkal and others added 30 commits November 24, 2023 13:26
@sahkal sahkal added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-feature Category: Feature request or enhancement labels Jan 8, 2024
@sahkal sahkal added this to the December 2023 Release milestone Jan 8, 2024
Base automatically changed from payment-link-api-contract-change to main January 8, 2024 12:25
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 9, 2024
@sahkal sahkal requested a review from Narayanbhat166 January 9, 2024 12:44
@sahkal sahkal changed the title feat(payment_link): add 404 not found page payment link feat(payment_link): add status page for payment link Jan 9, 2024
Narayanbhat166
Narayanbhat166 previously approved these changes Jan 9, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 50e4d79 Jan 10, 2024
@likhinbopanna likhinbopanna deleted the 404-not-found-page-payment-link branch January 10, 2024 08:37
pixincreate added a commit that referenced this pull request Jan 11, 2024
* 'main' of github.com:juspay/hyperswitch:
  ci: use git commands for pushing commits and tags in nightly release workflows (#3314)
  refactor(connector): [bluesnap] add connector_txn_id fallback for webhook (#3315)
  feat(core): add new payments webhook events (#3212)
  chore: nits and small code improvements found during investigation of PR#3168 (#3259)
  refactor: removed basilisk feature (#3281)
  fix(euclid_wasm): Update braintree config prod (#3288)
  feat(payment_link): add status page for payment link (#3213)
  chore(version): 2024.01.10.0
  chore(postman): update Postman collection files
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants