Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update miniforge to 4.10.1 and python version to 3.9.2 #1289

Merged
merged 1 commit into from
May 6, 2021
Merged

Update miniforge to 4.10.1 and python version to 3.9.2 #1289

merged 1 commit into from
May 6, 2021

Conversation

mathbunnyru
Copy link
Member

This is a follow up on #1286

@romainx
Copy link
Collaborator

romainx commented May 6, 2021

😆 You were against moving to python 3.9.

@mathbunnyru
Copy link
Member Author

😆 You were against moving to python 3.9.

No! :) :)

I didn't want us to move to python 3.9 without even noticing it.
I just wanted it to be explicitly visible.

I'm absolutely ok with moving, in a separate commit, which is easy to revert :)

romainx
romainx approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@romainx romainx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say, this test is perfect 😆

@romainx romainx merged commit 09fb660 into jupyter:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainx romainx romainx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathbunnyru @romainx