Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribution Page for Jupyter Server #1499

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

kjayan
Copy link
Contributor

@kjayan kjayan commented Feb 10, 2025

The following updates are made to the contributing page .

  1. During building the docs, errors related to non availability of sphinx can happen. New instructions are added to install this package and its related dependencies
  2. Changed format for the line pip install hatch hatch run docs:build to reflect it properly
  3. Added double quotes which were missing for some commands like pip install ".[docs]" and pip install ".[test]"

@kjayan kjayan marked this pull request as draft February 10, 2025 16:18
@kjayan kjayan marked this pull request as ready for review February 11, 2025 05:05
@kjayan kjayan force-pushed the documentation-updates branch 2 times, most recently from 9133eb2 to f1b7315 Compare February 11, 2025 11:14
@kjayan kjayan force-pushed the documentation-updates branch from e6bc218 to 5a2c922 Compare February 12, 2025 12:33
@kjayan kjayan force-pushed the documentation-updates branch 2 times, most recently from 159c3df to bacf845 Compare February 13, 2025 08:39
@kjayan kjayan requested a review from 3coins February 17, 2025 16:28
@kjayan kjayan force-pushed the documentation-updates branch from 9872c8a to bbd3be3 Compare February 22, 2025 19:15
Copy link
Contributor

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

:show-inheritance:
:undoc-members:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order make a difference here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that, but the CI is generating the same changes, this was what failed the CI in previous commits. @kjayan Would help to check with others in the JupyterLab weekly call, before we merge.

Copy link

@andrii-i andrii-i Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging @vidartf as discussed in the community call.

@danyeaw
Copy link

danyeaw commented Mar 5, 2025

I reviewed this following the topic coming in to the Jupyter Frontends and Accessibility call. These looks like some great documentation improvements.

@vidartf vidartf merged commit 8cb231c into jupyter-server:main Mar 7, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants