Skip to content
This repository was archived by the owner on Oct 18, 2022. It is now read-only.

adds From for option types #76

Merged
merged 1 commit into from
Nov 2, 2021
Merged

adds From for option types #76

merged 1 commit into from
Nov 2, 2021

Conversation

wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Nov 2, 2021 •
edited
Loading

Allows options to be converted into Value!

This is useful for the project that I'm doing, and maybe it'll be useful for someone else!

jonas-schievink
jonas-schievink reviewed Nov 2, 2021
View reviewed changes
Copy link
Owner

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one for Option<&'a str> as well? That's the only From impl that doesn't have an Option counterpart

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Nov 2, 2021

Can you add one for Option<&'a str> as well? That's the only From impl that doesn't have an Option counterpart

added!

@jonas-schievink jonas-schievink merged commit 49b434d into jonas-schievink:master Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgahnagl @jonas-schievink