Fix LITTLEFS_MALLOC_STRATEGY_SPIRAM depends. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP32_SPIRAM_SUPPORT has been renamed to SPIRAM since IDF 5.0: espressif/esp-idf@0687daf#diff-23044c90e9c0d809dc2befbe42491cd077bf06445cd24e6acba7784ea5f28b27R20 Also checking for SPIRAM support is not necessary, as SPIRAM_USE_MALLOC already depends on SPIRAM. Additionally allocating using heap_caps_malloc(..., MALLOC_CAP_SPIRAM) is also possible if SPIRAM_USE_CAPS_ALLOC is set (then SPIRAM is **only** allocatable with heap_caps_malloc, not with malloc)
|
thank you! this is now in v1.18.1 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32_SPIRAM_SUPPORT has been renamed to SPIRAM since IDF 5.0: espressif/esp-idf@0687daf#diff-23044c90e9c0d809dc2befbe42491cd077bf06445cd24e6acba7784ea5f28b27R20
Also checking for SPIRAM support is not necessary, as SPIRAM_USE_MALLOC already depends on SPIRAM.
Additionally allocating using heap_caps_malloc(..., MALLOC_CAP_SPIRAM) is also possible if SPIRAM_USE_CAPS_ALLOC is set (then SPIRAM is only allocatable with heap_caps_malloc, not with malloc)