Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Push StreamId out to FsCodec #419

Merged
merged 16 commits into from
Aug 8, 2023
Merged

feat!: Push StreamId out to FsCodec #419

merged 16 commits into from
Aug 8, 2023

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Aug 5, 2023

See also jet/FsCodec#100

  • first cut done
  • removed Cosmos/Dynamo wacky mapping overrides (strong types make wacky hack code stick out a mile!)
  • move Tracing and Category into Equinox (drags in FsCodec and Serilog)
  • move Impl from top of Decider.fs to Stream.fs (renamed from Core.fs)
  • review if anything should be added to FsCodec (don't want to put any extensions in Equinox/Equinox.Core)
  • considered dragging in Cache and Caching, but that drags in AsyncCacheCell too (and System.MemoryCache ref). Thoughts ? Ultimately there are no interesting stores that don't ref it?
  • Apply module Stream pattern as per FsCodec throughout samples/integration tests
    cc @nordfjord

@bartelink bartelink marked this pull request as ready for review August 7, 2023 10:12
@bartelink bartelink changed the title feat: Push StreamId out to FsCodec feat!: Push StreamId out to FsCodec Aug 8, 2023
@bartelink bartelink merged commit caee095 into master Aug 8, 2023
@bartelink bartelink deleted the ids branch August 8, 2023 11:29
@bartelink bartelink mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants