-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JestObjectAPI.md #5559
Update JestObjectAPI.md #5559
Conversation
small typo :)
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5559 +/- ##
======================================
Coverage 61.7% 61.7%
======================================
Files 213 213
Lines 7150 7150
Branches 4 4
======================================
Hits 4412 4412
Misses 2737 2737
Partials 1 1 Continue to review full report at Codecov.
|
docs/JestObjectAPI.md
Outdated
@@ -158,7 +158,7 @@ as well as all the modules that it imports._ | |||
|
|||
Modules that are mocked with `jest.mock` are mocked only for the file that calls | |||
`jest.mock`. Another file that imports the module will get the original | |||
implementation even if run after the test file that mocks the module. | |||
implementation even if runs after the test file that mocks the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shaneu, thanks for the fix
This seems wrong to me, did you mean to change this to:
even if it runs after the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man, I saw that run was missing an 's', totally missed that it was also missing 'it'! Yes, that's what I meant/
* Update JestObjectAPI.md small typo :) * Update JestObjectAPI.md
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
small typo :)
Summary
Just a small typo, missing an 's'
Test plan
no test necessary