-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] Refactored a part of SpanReader to make it reusable for V2 APIs #6824
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
This reverts commit 2760cdc. Signed-off-by: Manik2708 <[email protected]>
…PIs" This reverts commit 1fb531d. Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
@@ -591,7 +645,7 @@ func (s *SpanReader) findTraceIDs(ctx context.Context, traceQuery *spanstore.Tra | |||
searchResult, err := searchService.Do(ctx) | |||
if err != nil { | |||
err = es.DetailedError(err) | |||
s.logger.Info("es search services failed", zap.Any("traceQuery", traceQuery), zap.Error(err)) | |||
s.logger.Info("es search services failed", zap.Any("traceQuery", serviceName), zap.Error(err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should I log this? Query can't be accessed by this method as it is to be used in V2 also!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6824 +/- ##
==========================================
+ Coverage 96.05% 96.07% +0.02%
==========================================
Files 364 364
Lines 20712 20742 +30
==========================================
+ Hits 19894 19927 +33
+ Misses 624 622 -2
+ Partials 194 193 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mahadzaryab1 @yurishkuro This PR tries to make
Or we have to re-implement the multiread method by making some query methods as public (which will be used in the new multiread) |
@Manik2708 the DB layer treats IDs as strings, so the underlying reader can accept them as strings and make it the responsibility of v1/v2 readers to do a conversion |
Which problem is this PR solving?
Fixes a part of: #6458
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test