-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lfs: add tests for rate limit retries #341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 77.38% 78.78% +1.39%
==========================================
Files 39 39
Lines 5081 5156 +75
Branches 915 931 +16
==========================================
+ Hits 3932 4062 +130
+ Misses 994 930 -64
- Partials 155 164 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sisp ! good stuff. Feel free to merge (we usually do squash merge I think) and probably you should be able to trigger the new release (releases -> create a new release I think). We can then bump the version required on the DVC side if you feel it is needed.
Thanks for the helpful review, @shcheklein! 🙇 IMO, no release is needed, as the only change since the last one is the added tests by this PR. v3.3.0 already includes the feature. No need for a bump in DVC from my side, |
I've added some tests for rate limit retries.
Follow-up of #340.
/cc @shcheklein