pygit2: support 1.14 credentials #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
commented
Jan 29, 2024
| if os.name == "nt" and url.startswith("file://"): | ||
| url = url[len("file://") :] | ||
|
|
||
| yield self.repo.remotes.create_anonymous(url) | ||
| remote = self.repo.remotes.create_anonymous(url) |
There was a problem hiding this comment.
create_anonymous will apply any configured URL rewrite rules (like insteadOf) before setting the returned remote.url, we should be checking the rewritten URL for SSH rather than the raw URL
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 78.35% 78.34% -0.02%
==========================================
Files 39 39
Lines 4980 4982 +2
Branches 897 897
==========================================
+ Hits 3902 3903 +1
- Misses 924 925 +1
Partials 154 154 ☔ View full report in Codecov by Sentry. |
pmrowla
force-pushed
the
pygit2-1.14-creds
branch
from
af6500e to
7966177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311