Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc repro: pygit2 update breaking changes #10431

Closed
SimiPro opened this issue May 19, 2024 · 3 comments · Fixed by iterative/scmrepo#359 or #10432
Closed

dvc repro: pygit2 update breaking changes #10431

SimiPro opened this issue May 19, 2024 · 3 comments · Fixed by iterative/scmrepo#359 or #10432
Assignees
@shcheklein
Labels
bug Did we break something? dependencies Pull requests that update a dependency file p1-important Important, aka current backlog of things to do

Comments

@SimiPro
Copy link

SimiPro commented May 19, 2024

Bug Report

Description

pygit2 renamed GIT_OBJ_COMMIT to GIT_OBJECT_COMMIT (I think)
because we get error GIT_OBJ_COMMIT not found.

Reproduce

install newest dvc , run dvc repro

Expected

no crash

Environment information

Output of dvc doctor:

$ dvc doctor

Additional Information (if any):

you can fix it by using pip install pygit2==1.14.1
@shcheklein shcheklein mentioned this issue May 19, 2024
Merged
@shcheklein shcheklein self-assigned this May 19, 2024
@shcheklein shcheklein added bug Did we break something? dependencies Pull requests that update a dependency file p1-important Important, aka current backlog of things to do labels May 19, 2024
@shcheklein
Copy link
Member

Should be fixed by iterative/scmrepo#359

skshetry added a commit that referenced this issue May 20, 2024
@skshetry
deps: bump scmrepo to >=3.3.4
0656011 
Closes #10431.

Upstream PR: iterative/scmrepo#359
@skshetry skshetry mentioned this issue May 20, 2024
Merged
skshetry added a commit that referenced this issue May 20, 2024
@skshetry
deps: bump scmrepo to >=3.3.4 (#10432)
e82356b 
Closes #10431.

Upstream PR: iterative/scmrepo#359
@Lhenzo
Copy link

Lhenzo commented May 22, 2024

Hello,

Thank you for the bump. Is there any release planned soon to make this available?

Thank you

@shcheklein
Copy link
Member

yes, we'll do a release soon.

abhipreets2 referenced this issue in abhipreets2/cybulde-data-preparation Jul 9, 2024
@abhipreets2
downgraded pygit2 to solve dvc issue
4b106f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shcheklein shcheklein

Labels
bug Did we break something? dependencies Pull requests that update a dependency file p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
3 participants
@SimiPro @shcheklein @Lhenzo