-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax Pandas dependency requirement to allow >v2 #596
Relax Pandas dependency requirement to allow >v2 #596
Conversation
Signed-off-by: Natan Mish <[email protected]>
0489ed5
to
ff1e9f0
Compare
looks like there were some flake8 errors in the build due to updates to dependencies - I am guessing this needs a separate PR, let me send one out |
Link to issue: #595 |
I sent a PR here to fix the flake8 errors: |
I also updated the PR to pin scikit-learn as I see one of the tests started failing with scikit-learn 1.5.0 release |
@NatanMish please rebase this PR against latest main, I've merged PR #597 to fix the build errors |
close re-open to re-run notebook tests |
although the build is green it doesn't look like we are testing against pandas >2.0? |
seems like something else is still pinning it to older version in tests, strange |
@imatiach-msft Thanks for looking into this. I have never contributed to this project before. What would you suggest for the next steps? |
@NatanMish maybe for now I will go ahead and merge this. My suspicion is that the ml-wrappers library that interpret-community depends on is bringing in this pandas<2.0 dependency, so we need to fix it there as well. |
Great thank you, when is the next planned release? |
I think we still need to resolve the issue in ml-wrappers first. However, the build seems to be broken there right now as well based on PR microsoft/ml-wrappers#175, which may take some work. |
Otherwise we are de facto still pulling and using the pinned version |
No description provided.