ci: Deploy storybook on gh-pages #937
Conversation
mayank99
force-pushed
the
mayank/gh-pages-storybook
branch
5 times, most recently
from
bbc22bc to
7c100e4
Compare
mayank99
requested review from
a team,
gretanausedaite,
elephantcatdog and
r100-stack
and removed request for
a team and
elephantcatdog
mayank99
force-pushed
the
mayank/gh-pages-storybook
branch
from
7c100e4 to
648bfe1
Compare
|
|
||
| jobs: | ||
| publish-storybook: | ||
| if: "${{ github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'autorelease: tagged') }}" |
There was a problem hiding this comment.
previously (before merging repos) we were deploying storybook manually or whenever a release happened. but now it will be deployed automatically on every push.
if we want the old behavior, we can look into it after #875. changesets has a way to run arbitrary steps after a release is made. https://github.com/changesets/action#with-publishing
There was a problem hiding this comment.
I think it's good to deploy storybook after every merge to main. Sometimes we forget to do that manually.
That said, I think it's good to have an option to deploy manually in case we need to do that from a branch.
By default, storybook will automatically be deployed for every PR for preview. I've added back manual publish workflow, but using it will override the default storybook at |
Before
/or/<pr-number>Now (in/after this PR)
portal(from chore: Add new portal containing links to all dev servers #936) under/or/<pr-number>/cssor/<pr-number>/css/reactor/<pr-number>/reactPending issues
gh-pagesbranch even after PR is closed/merged