Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(critical): tonic::Streaming enters infinite loop on response error #2199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Suficio
Copy link

@Suficio Suficio commented Mar 4, 2025

Motivation

tonic::Streaming enters an infinite loop if an HTTP error is received during stream operation.

Typically this happens if the server cuts the connection.

This was not caught as users typically implement re-connect logic when the first error is emitted by tonic::Streaming, however, this does not hold if the implementation expects the stream to exit.

Solution

Correctly handle response errors within the state machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant