fix(critical): tonic::Streaming
enters infinite loop on response error
#2199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tonic::Streaming
enters an infinite loop if an HTTP error is received during stream operation.Typically this happens if the server cuts the connection.
This was not caught as users typically implement re-connect logic when the first error is emitted by
tonic::Streaming
, however, this does not hold if the implementation expects the stream to exit.Solution
Correctly handle response errors within the state machine.