Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async_closure feature gate where needed #288

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Add async_closure feature gate where needed #288

merged 1 commit into from
Jul 9, 2019

Conversation

spastorino
Copy link
Contributor

@spastorino spastorino commented Jul 9, 2019 •
edited
Loading

This PR adds async_closure feature gate to the crates that use the feature, in tests and example to make everything compile and work properly again.

This is related to the recent change done in rust-lang/rust#62292

@spastorino spastorino force-pushed the add-async_closure branch 2 times, most recently from 7b17984 to ddb23df Compare July 9, 2019 12:54
@spastorino spastorino force-pushed the add-async_closure branch from ddb23df to da33e3d Compare July 9, 2019 13:08
yoshuawuyts
yoshuawuyts approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@yoshuawuyts yoshuawuyts merged commit 36c15fd into http-rs:master Jul 9, 2019
@fitzgen
Copy link

fitzgen commented Jul 12, 2019

Care to publish a new version when you have a chance? Happy to use a git dependency in the meantime, so no rush :)

@taiki-e
Copy link
Contributor

taiki-e commented Jul 14, 2019 •
edited
Loading

I think we probably need to release a new version of http-service* and update version of them (and get rid of the patch field from Cargo.toml) before releasing a new version of tide. because the current tide's master branch depends on http-service's master branch, not http-service, which has been released.

https://github.com/rustasync/tide/blob/36c15fd4ca67fcb269e7bc87d2ceb6eeb8826483/Cargo.toml#L77-L80

@taiki-e taiki-e mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spastorino @fitzgen @taiki-e @yoshuawuyts