Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resource mode while bundling notebook assets #7716

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

philippjfr
Copy link
Member

Two things:

  1. Seemingly we never correctly applied the resource mode while bundling resources (which presumably had some effect on bundling resources for custom components)
  2. We already had a context manager to handle it

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (b2cb0c3) to head (136caa1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/notebook.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7716   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         346      346           
  Lines       52675    52671    -4     
=======================================
  Hits        45865    45865           
+ Misses       6810     6806    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit b17ddfd into main Feb 13, 2025
17 checks passed
@philippjfr philippjfr deleted the set_resource_mode_bundle branch February 13, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant