Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure type checkers can correctly infer extension argument types #7709

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

philippjfr
Copy link
Member

Seems like type checkers get confused about ParameterizedFunction signatures so we help them a little bit with a typing.overload.

Fixes #7690

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (56d9055) to head (c96e252).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
panel/config.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7709      +/-   ##
==========================================
+ Coverage   87.04%   87.08%   +0.04%     
==========================================
  Files         346      346              
  Lines       52625    52657      +32     
==========================================
+ Hits        45806    45858      +52     
+ Misses       6819     6799      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Simon Høxbro Hansen <[email protected]>
@philippjfr philippjfr merged commit b674365 into main Feb 13, 2025
17 of 18 checks passed
@philippjfr philippjfr deleted the extension_typing branch February 13, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyright giving Expected 0 positional arguments for pn.extension() calls
2 participants