Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure root_url is correctly determined during auth #7680

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 31, 2025

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 24.79339% with 91 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (c2c2d9c) to head (071860a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/test_auth.py 23.28% 56 Missing ⚠️
panel/auth.py 8.33% 22 Missing ⚠️
panel/command/serve.py 22.22% 7 Missing ⚠️
panel/tests/util.py 60.00% 4 Missing ⚠️
panel/io/server.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7680      +/-   ##
==========================================
- Coverage   86.63%   86.04%   -0.60%     
==========================================
  Files         346      346              
  Lines       52530    52625      +95     
==========================================
- Hits        45510    45280     -230     
- Misses       7020     7345     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr marked this pull request as ready for review February 12, 2025 13:31
@philippjfr philippjfr merged commit cf32785 into main Feb 12, 2025
15 of 17 checks passed
@philippjfr philippjfr deleted the auth_root_url branch February 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid azure oauth redirect when using prefix
2 participants