Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator: fix selected row in the UI with add_filter #7534

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 4, 2024

Just a test for now, it will address #7505 :)

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (bbde851) to head (b9e06ac).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7534      +/-   ##
==========================================
+ Coverage   87.05%   87.07%   +0.01%     
==========================================
  Files         346      346              
  Lines       52655    52673      +18     
==========================================
+ Hits        45839    45865      +26     
+ Misses       6816     6808       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt marked this pull request as draft December 4, 2024 12:04
@philippjfr
Copy link
Member

Should be fixed by #7712

@philippjfr philippjfr marked this pull request as ready for review February 13, 2025 12:10
@philippjfr philippjfr enabled auto-merge (squash) February 13, 2025 12:53
@philippjfr philippjfr disabled auto-merge February 13, 2025 12:57
@philippjfr philippjfr merged commit b2cb0c3 into main Feb 13, 2025
17 of 18 checks passed
@philippjfr philippjfr deleted the fix_tabulator_selection_filter_ui branch February 13, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants