Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parameter overrides are applied to ESM components #7452

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

philippjfr
Copy link
Member

Fixes issue that caused a parameter inherited from a baseclass not to be correctly overridden.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (f712587) to head (3cd6039).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7452   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         338      338           
  Lines       50764    50772    +8     
=======================================
+ Hits        41766    41775    +9     
+ Misses       8998     8997    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit b43a52a into main Oct 31, 2024
17 checks passed
@philippjfr philippjfr deleted the override_custom_component_param branch October 31, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant