Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ESM compilation correctly detects file extension #7446

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

philippjfr
Copy link
Member

When compiling a component pointing to an ESM file on disk it was incorrectly adding a leading period, leading to compile errors.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (26c2e7a) to head (f89bcc3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/compile.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7446      +/-   ##
==========================================
- Coverage   82.25%   82.25%   -0.01%     
==========================================
  Files         337      337              
  Lines       50678    50680       +2     
==========================================
  Hits        41685    41685              
- Misses       8993     8995       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d4e02f4 into main Oct 27, 2024
16 of 17 checks passed
@philippjfr philippjfr deleted the esm_build_ext_fix branch October 27, 2024 11:00
@philippjfr philippjfr added this to the v1.5.4 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant