Patch HoloViews client comm to ensure server comm is initialized #6234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HoloViews has it's own code to initialize Jupyter comms here: https://github.com/holoviz/holoviews/blob/main/holoviews/plotting/renderer.py#L408
Sadly this means that the recent changes in #6229 to have the client Comm be responsible to initialize the server comm does not work for HoloViews. For now we therefore have to manually patch the client comm created by HoloViews with the required
on_open
callback. I will separately open a PR in HoloViews to add theon_open
handler properly.