Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DataModel children can be correctly cleaned up #5924

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

philippjfr
Copy link
Member

Fixes #3581
Fixes #5920

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (16f876a) 41.14% compared to head (bec2436) 84.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
panel/reactive.py 85.00% 3 Missing ⚠️
panel/io/datamodel.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5924       +/-   ##
===========================================
+ Coverage   41.14%   84.15%   +43.01%     
===========================================
  Files         291      291               
  Lines       42793    42807       +14     
===========================================
+ Hits        17606    36024    +18418     
+ Misses      25187     6783    -18404     
Flag Coverage Δ
ui-tests 40.92% <12.50%> (+<0.01%) ⬆️
unitexamples-tests 72.43% <79.16%> (+49.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2867559 into main Nov 27, 2023
@philippjfr philippjfr deleted the reactive_html_cleanup branch November 27, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant