Fix race conditions when initializing and rendering IPyWidgets #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
reviewed
Aug 31, 2023
philippjfr
force-pushed
the
ipywidget_render_fix
branch
from
b9e58cf to
e541c3f
Compare
Codecov Report
@@ Coverage Diff @@
## main #5462 +/- ##
===========================================
- Coverage 70.07% 23.67% -46.41%
===========================================
Files 274 274
Lines 40089 40089
===========================================
- Hits 28094 9490 -18604
- Misses 11995 30599 +18604
Flags with carried forward coverage won't be shown. Click here to find out more. see 171 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering IPyWidgets in a notebook there was a race condition which meant that because lazy_initialize was slow you could end up with multiple Views for the same model.
@mattpap While I realize I was inappropriately using lazy_initialize here I think this revealed a bokeh bug where there could be a race condition where
this._child_viewswas reset while a view was still initializing meaning that it was never cleaned up (or reused).Fixes #5459