Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure session arguments are correctly parsed by Jupyter executor #5106

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

philippjfr
Copy link
Member

Session arguments were not unpacked correctly resulting in the theme toggle in the Fast templates to break.

@philippjfr philippjfr added this to the v1.1.1 milestone Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #5106 (402970e) into main (5f30ba9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5106   +/-   ##
=======================================
  Coverage   83.70%   83.71%           
=======================================
  Files         274      274           
  Lines       39219    39257   +38     
=======================================
+ Hits        32830    32864   +34     
- Misses       6389     6393    +4     
Flag Coverage Δ
ui-tests 40.41% <75.00%> (-0.04%) ⬇️
unitexamples-tests 73.81% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/jupyter_executor.py 0.00% <ø> (ø)
panel/tests/ui/io/test_jupyter_server_extension.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 31e2d9e into main Jun 13, 2023
@philippjfr philippjfr deleted the jupyter_execute_arguments branch June 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant