Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Param._mapping public #3173

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Make Param._mapping public #3173

merged 2 commits into from
Feb 3, 2022

Conversation

philippjfr
Copy link
Member

Only makes the attribute public for now, the suggestions in #1348 are still valid and that issue will stay open.

Supersedes #1322
Fixes #620

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #3173 (8267435) into master (f1502c6) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
- Coverage   82.98%   82.97%   -0.02%     
==========================================
  Files         192      192              
  Lines       25502    25506       +4     
==========================================
  Hits        21163    21163              
- Misses       4339     4343       +4     
Impacted Files Coverage Δ
panel/param.py 86.83% <85.71%> (-0.21%) ⬇️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1502c6...8267435. Read the comment docs.

@philippjfr philippjfr merged commit 1dcd862 into master Feb 3, 2022
@philippjfr philippjfr deleted the param_mapping_public branch February 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

param types vs panel widgets
1 participant