Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quill.js based TextEditor widget #2875

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Add quill.js based TextEditor widget #2875

merged 7 commits into from
Nov 3, 2021

Conversation

philippjfr
Copy link
Member

The Ace editor is a bit heavyweight while the TextArea is a bit too simple for many use cases so we add a WYSIWYG editor which accepts and outputs HTML:

Screen Shot 2021-11-02 at 6 41 58 PM

@philippjfr philippjfr added this to the 0.13.0 milestone Nov 2, 2021
@philippjfr philippjfr changed the title Add quill.js based WYSIWYG widget Add quill.js based TextEditor widget Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2875 (7810f62) into master (abea3b0) will increase coverage by 0.03%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
+ Coverage   83.04%   83.08%   +0.03%     
==========================================
  Files         188      190       +2     
  Lines       24460    24524      +64     
==========================================
+ Hits        20313    20375      +62     
- Misses       4147     4149       +2     
Impacted Files Coverage Δ
panel/config.py 58.95% <ø> (ø)
panel/widgets/ace.py 100.00% <ø> (ø)
panel/models/quill.py 86.36% <86.36%> (ø)
panel/widgets/__init__.py 100.00% <100.00%> (ø)
panel/widgets/texteditor.py 100.00% <100.00%> (ø)
panel/tests/test_param.py 99.87% <0.00%> (+<0.01%) ⬆️
panel/param.py 87.67% <0.00%> (+0.04%) ⬆️
panel/util.py 82.73% <0.00%> (+1.20%) ⬆️
panel/auth.py 40.80% <0.00%> (+1.64%) ⬆️
panel/io/reload.py 71.11% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abea3b0...7810f62. Read the comment docs.

@philippjfr philippjfr merged commit d13e5f6 into master Nov 3, 2021
@philippjfr philippjfr deleted the wysiwyg branch November 3, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant