Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add-system.tsx docker-compose.yml template. #565

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

kmcfate
Copy link
Contributor

@kmcfate kmcfate commented Feb 13, 2025

Adding version: "3" makes this compatible with more recent docker tools.

Otherwise get error:

ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services: 'beszel-agent'

Adding `version: "3"` makes this compatible with more recent docker tools.
@henrygd henrygd merged commit 4f80a58 into henrygd:main Feb 14, 2025
@henrygd
Copy link
Owner

henrygd commented Feb 14, 2025

Thanks 👍

@jpbaril
Copy link

jpbaril commented Feb 19, 2025

Funny because "version" is now obsolete in recent docker releases: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete

@henrygd
Copy link
Owner

henrygd commented Feb 19, 2025

Yeah, I didn't realize that happened. Docker now gives this message: "the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion"

So I'll probably remove it.

@jpbaril
Copy link

jpbaril commented Feb 19, 2025

So I'll probably remove it.

Well, in the foreseeable future you could keep it as it seems that per kmcfate in some cases it will not work at all if absent whereas in our case it will simple give a warning in the logs as you saw.

@henrygd
Copy link
Owner

henrygd commented Feb 19, 2025

Kind of a lose/lose situation. If we include it then people will likely make PRs or bug reports asking to remove it because Docker prints a warning that says "please remove it."

From a quick look at some larger projects it seems most don't include the version attribute.

If it's not in the spec anymore then I'm not sure that we should include it. From Docker's perspective it seems clear that they want it gone. Including it will continue to make people think it does something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants