-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #33 Mostly working version of baseURL #518
Conversation
Issues- - Pocketbase doesnt autologin - maybe related, public key is empty. - baseURL has to be configured at build time, and I couldnt get a build env to work.
Main issue is the 3rd one, seems like Base url needs to be configured at build time, rather than run time. vitejs/vite#15674 I tested this with this nginx conf, and i didnt test alerts, but i think most of everything else worked.
I am a light user though, maybe my definition of "everything" isnt complete :D |
TODO
|
Thanks, I've also been working on this. I have it so you can pass in an env var like I've got it working for the most part, but it requires setting up the path with your proxy like you outlined above. If I can figure out a way to change the PocketBase admin path to use the subpath then we can do this without needing additional proxy configuration, but I'm not sure there's a way to do this yet. In any case this will definitely be in the next release. |
Cool, am curious to see how you got it working. Pocketbase seems to prefer the rewrite, as it is in their reverse proxy docs and I saw a question get answered that way as well. |
I made a branch with my changes here: https://github.com/henrygd/beszel/tree/base-path Seems to work pretty well with I'd also like to get it working in dev mode if possible. |
I merged my changes and added you as a coauthor to give you credit for the work you did on this 👍 |
Oh thank you so much! Good to see the feature land! |
Issues-