Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package-lock.json): fix for nixpkgs #199

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

Bot-wxt1221
Copy link
Contributor

@Bot-wxt1221 Bot-wxt1221 commented Oct 3, 2024

run npm-lockfile-fix.

@henrygd
Copy link
Owner

henrygd commented Oct 3, 2024

Sorry, can you explain very briefly what you did here?

It's been a long time since I used npm as my package manager and googling "npm-lockfile-fix" didn't turn up anything.

I tested npm i and npm run build and it seems to work fine with the current files.

Also, I forgot to ask earlier, but would it help if I added a makefile for building?

@Bot-wxt1221
Copy link
Contributor Author

Bot-wxt1221 commented Oct 3, 2024

@henrygd I run https://github.com/jeslie0/npm-lockfile-fix for package-lock.json. It's a small python script that add resolved and integrity to package-lock.json. We should have "resolved" and "integrity" in package-lock.json for nixpkgs. Makefile doesn't work anyway. When building package in nixpkgs, there's no network so we should download all thing before building and make sure they won't change. That's what these two pattern do.

@henrygd henrygd merged commit 13c9497 into henrygd:main Oct 4, 2024
@henrygd
Copy link
Owner

henrygd commented Oct 4, 2024

@Bot-wxt1221 Thanks for explaining.

Do you need another release before adding to nixpkgs?

@Bot-wxt1221
Copy link
Contributor Author

Bot-wxt1221 commented Oct 4, 2024

@henrygd OK! Thanks for your patience. I feel so sorry that I didn't test before the release.

@henrygd
Copy link
Owner

henrygd commented Oct 5, 2024

@Bot-wxt1221 No problem at all, thank you for your help. I just released another version (0.5.2) if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants