Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considers isalhum in pdb_selchain #40

Merged
merged 4 commits into from
Sep 26, 2019

Conversation

joaomcteixeira
Copy link
Member

Considers chain options to be valid when str.isalnum() is True.

Solves #39

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          44       44           
  Lines        3525     3525           
  Branches      742      742           
=======================================
  Hits         2893     2893           
  Misses        446      446           
  Partials      186      186
Impacted Files Coverage Δ
pdbtools/pdb_selchain.py 84.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1baf7...ba556bf. Read the comment docs.

@mtrellet
Copy link
Member

Works fine on my side! Thanks ;)

Copy link
Member

@JoaoRodrigues JoaoRodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Mind adding a test to check this? (A small example with 3 chains, A, a, and B where we select each would work).

@joaomcteixeira
Copy link
Member Author

Added tests for selecting capital chain identifiers, lowercase identifiers and digit identifiers.

@JoaoRodrigues review and merge if appropriate.

@JoaoRodrigues
Copy link
Member

Seems good! Thanks for the fix and the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants