-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Considers isalhum in pdb_selchain #40
Considers isalhum in pdb_selchain #40
Conversation
updating to the master
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 82.07% 82.07%
=======================================
Files 44 44
Lines 3525 3525
Branches 742 742
=======================================
Hits 2893 2893
Misses 446 446
Partials 186 186
Continue to review full report at Codecov.
|
Works fine on my side! Thanks ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Mind adding a test to check this? (A small example with 3 chains, A, a, and B where we select each would work).
Added tests for selecting capital chain identifiers, lowercase identifiers and digit identifiers. @JoaoRodrigues review and merge if appropriate. |
Seems good! Thanks for the fix and the tests! |
Considers chain options to be valid when str.isalnum() is True.
Solves #39