Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/worker health check & recreation #28

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feature/worker health check & recreation #28

merged 1 commit into from
Feb 18, 2025

Conversation

stanley2058
Copy link
Collaborator

This PR made the following changes:

  • Remove persist worker from api.js since nothing uses it in that file.
  • Replace persistWorker with getPersistWorker to allow worker recreation in the socket io server.
  • Implements a health check mechanism that terminates and recreates an unresponsive worker thread.

Example of a health check message:
Screenshot_20250212_120045

Example of an unhealthy worker being replaced:
Screenshot_20250212_115942

EastSun5566
EastSun5566 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@EastSun5566 EastSun5566 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yukaii Yukaii merged commit 647e1c6 into main Feb 18, 2025
1 check passed
@Yukaii Yukaii deleted the feature/worker-thread-health-check branch February 18, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EastSun5566 EastSun5566 EastSun5566 approved these changes

@Yukaii Yukaii Awaiting requested review from Yukaii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanley2058 @EastSun5566 @Yukaii