-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minio migration via hooks #1860
Conversation
Signed-off-by: Jason Heath <[email protected]>
… was run Signed-off-by: Jason Heath <[email protected]>
@jasonheath I didn't get too far with this:
The install completed but builder-minio was in the The prerequisites check could be avoided as long as the prerequisite packages are in the pkg dependencies. |
components/builder-minio/habitat/config_install/minio-migration.sh
Outdated
Show resolved
Hide resolved
components/builder-minio/habitat/config_install/minio-migration.sh
Outdated
Show resolved
Hide resolved
components/builder-minio/habitat/config_install/minio-migration.sh
Outdated
Show resolved
Hide resolved
components/builder-minio/habitat/config_install/minio-migration.sh
Outdated
Show resolved
Hide resolved
- Removes all sudo, pulls dependencies into plan file - Removes _aws, _curl, and _jq - Redirects pgrep and pkill stderr to /dev/null - Changes use of | tee to &> on minio hab execs - Adds messaging about possible long runtime of cp command - Adds --endpoint-url back to aws command calls - Cuts down envvar usage in favor of plan vars Signed-off-by: Jason Heath <[email protected]>
a1dc06d
to
67f0098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Obvious fix; these changes are the result of automation not creative thinking.
Implements minio migration via hooks.
Has related changes in habitat-sh/on-prem-builder#278