-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce string allocations in IConsoleOutput implementations #3978
Open
TheTonttu
wants to merge
11
commits into
gui-cs:v2_develop
Choose a base branch
from
TheTonttu:reduce-console-output-string-allocations
base: v2_develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reduce string allocations in IConsoleOutput implementations #3978
TheTonttu
wants to merge
11
commits into
gui-cs:v2_develop
from
TheTonttu:reduce-console-output-string-allocations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n<char> Allows the caller more flexibility about choosing a buffer per use case.
Writes cursor position sequence to text writer without string allocation.
…ly fields Changed for the sake of consistency with rest of the EscSegutils fields rather than performance. Also prevents bugs from accidentally setting the properties.
…buffer The large intermediate string builder remains a challenge. :)
Also might have missed one of the Console.Out.Write(StringBuilder) calls...
Regarding throttling in v2, I added
In #3949 And set it to ushort max for benchmark. But it is WIP, benchmark really needs better way of streaming the keys than TimedEvents |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
IConsoleOutput.Write(string)
toIConsoleOutput.Write(ReadOnlySpan<char>)
.Console.Out.Write(StringBuilder) -> TextWriter.Write(StringBuilder).
void CSI_WriteCursorPosition(TextWriter, int, int)
alternative tostring CSI_SetCursorPosition(int, int)
.Pull Request Checklist
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)UI Catalog benchmark
No noticeable change to times. Both v2win and v2net finished in ~03:48. I'm guessing the v2 application or drivers have input throttling/pacing which kind of makes the benchmark timings moot for them.
For comparison v1 Windows driver finished in ~00:35.
Microbenchmarks
CSI_SetCursorPosition vs CSI_WriteCursorPosition
Allocations
v2net
Reduced string allocations nicely.
v2win
Not that much improvement. Eliminated SetCursorVisibility char array and StringBuilder allocations.