Power event state improvements #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of 'Charging true' the alert displays time, power level & state/source Reuse method from heartbeat notifications
|
Had to add explicit receiver registration in monitor service in order to receive power events on Android 9 / Nokia 6.1.... otherwise, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #325
Sample output when unplugged & quickly reconnected:
Power
Feb 12, 2019 2:33:30 PM
POWER: 100%
STATE: Disconnected
Power
Feb 12, 2019 2:33:32 PM
POWER: 100%
STATE: USB Charging
Notes: faulty cable/connection may deliver odd power events as noted in #325. Testing concluded that voltage drops from a furnace, etc. can trigger a power event. Adding a delay would only add an attack vector (and false positives have been minimal). That said, testing and comments appreciated here.
I am going to look into making alerts configurable, with sensitivity options as suggested in #324 but for now I think this makes sense.