-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sms support #369
Remove sms support #369
Conversation
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
- take remote phone number for sending notification through Signal only Signed-off-by: Arka Prava Basu <[email protected]>
…_sms_support Signed-off-by: Arka Prava Basu <[email protected]>
- need to keep preference key same for data persistance in newer app versions Signed-off-by: Arka Prava Basu <[email protected]>
- switch is now only set when we can make a remote notification which means presence of remote number and a verified signal number Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Thanks for all the work on this. Forced adoption of Signal isn’t all bad, but it can be improved. Did a small, hands-on workshop w/this branch yesterday; group of ten users. Signal & encrypted messaging was discussed & demonstrated followed by Haven. *Users w/no prior knowledge of Haven
This is a tiny sample size from a tech-forward city. It did however contrast basic:advanced users and how they fell about learning two apps at the same time.
C’mon, Google, do the right thing. |
Some very insightful metrics there. Signal verification flow needs some UX improvements. Right now there is no way to tell whether verification is a success or failure. In the coming week will dig into the signal-CLI and see if something can be done. |
Yes, a basic step through Signal onboarding setup, explaining how to verify, would be helpful. We also need to explain the concept of whether you need a second "virtual" phone number or not. One idea I had was to see if Signal was installed on the phone or not. If not, then just go ahead using the device's built in phone number. Otherwise, we can show a screen that says "Looks like you are already using Signal on here. You'll need to get a second number, and here is how." |
No progress from Google contacts. Going to merge this, and then figure out a way to keep SMS as an option through an external APK of some kind, or perhaps a flavored build for F-Droid / APK download. |
Aims to solve #364
Changes
SEND_SMS
permission -> removed remote SMS notification feature.Some thoughts: