Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sms support #369

Merged
merged 9 commits into from
Feb 28, 2019
Merged

Conversation

archie94
Copy link
Collaborator

@archie94 archie94 commented Feb 10, 2019

Aims to solve #364

Changes

  • Removed SEND_SMS permission -> removed remote SMS notification feature.
  • On Settings the Switch for enabling SMS and Signal notifications now only enables remote notification through Signal.
  • on enabling the Switch we collect data required for remote notification ( a remote phone number, a verified signal phone number)
  • the String for the Switch name has been edited, we need to update translations for the same.

Some thoughts:

  • During on-boarding we may need to add a note to complete the Signal integration since having a remote number will not enable notification. IMO the Signal integration process is not very intuitive and can be further streamlined.

Arka Prava Basu and others added 4 commits February 10, 2019 12:03
Signed-off-by: Arka Prava Basu <[email protected]>
- take remote phone number for sending notification through Signal only

Signed-off-by: Arka Prava Basu <[email protected]>
- need to keep preference key same for data persistance in newer app versions

Signed-off-by: Arka Prava Basu <[email protected]>
- switch is now only set when we can make a remote notification which means
  presence of remote number and a verified signal number

Signed-off-by: Arka Prava Basu <[email protected]>
@archie94 archie94 changed the title WIP: Remove sms support Remove sms support Feb 14, 2019
@lukeswitz
Copy link
Collaborator

lukeswitz commented Feb 14, 2019

Thanks for all the work on this. Forced adoption of Signal isn’t all bad, but it can be improved.

Did a small, hands-on workshop w/this branch yesterday; group of ten users. Signal & encrypted messaging was discussed & demonstrated followed by Haven.

*Users w/no prior knowledge of Haven

  • 4/10 reported using Signal semi regularly/regularly.
  • 10/10 had a paint point in onboarding, edit: configuring signal.
  • 2/10 had problems trying to link signal. (Resolving was not simple, required emptying fields and restarting activities.)
  • 10/10 asked if two signal numbers are required
  • 5/10 said they’d use the app as is and enjoyed the experience.
  • 4/10 said they would use the app if Signal was not required.
  • 1/10 would not use this app in the future.

This is a tiny sample size from a tech-forward city. It did however contrast basic:advanced users and how they fell about learning two apps at the same time.

  • Users that understood encryption were highly receptive to using/registering Signal.

  • Some crashes were found when remote number is used without proper verification. Overall, better feedback than expected.

C’mon, Google, do the right thing.

@archie94
Copy link
Collaborator Author

Some very insightful metrics there. Signal verification flow needs some UX improvements. Right now there is no way to tell whether verification is a success or failure. In the coming week will dig into the signal-CLI and see if something can be done.

@n8fr8
Copy link
Member

n8fr8 commented Feb 14, 2019

Yes, a basic step through Signal onboarding setup, explaining how to verify, would be helpful. We also need to explain the concept of whether you need a second "virtual" phone number or not.

One idea I had was to see if Signal was installed on the phone or not. If not, then just go ahead using the device's built in phone number. Otherwise, we can show a screen that says "Looks like you are already using Signal on here. You'll need to get a second number, and here is how."

@n8fr8
Copy link
Member

n8fr8 commented Feb 28, 2019

No progress from Google contacts. Going to merge this, and then figure out a way to keep SMS as an option through an external APK of some kind, or perhaps a flavored build for F-Droid / APK download.

@n8fr8 n8fr8 merged commit 4226024 into guardianproject:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants