Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity | Add instructions on developing with okta/sign in local dev #27791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/01-start-here/01-installation-steps.md
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ Recommended VSCode extensions are listed in `.vscode/extensions.json` and VSCode
If you are working on Identity or Discussion, Nginx must be installed and
configured to correctly serve the application, please refer to
[`/nginx/README.md`](https://github.com/guardian/frontend/blob/main/nginx/README.md) in this project.
This will allow you to access frontend via `https://m.thegulocal.com`
This will allow you to access frontend via `https://m.thegulocal.com` and test signed in behaviour.

### Optional steps

Expand Down
12 changes: 12 additions & 0 deletions nginx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,15 @@ You need to install:
## Access the Site

Visit https://m.thegulocal.com/.

## Testing signed in behaviour

1. Sign in to https://profile.code.dev-theguardian.com/ on a separate tab/window

- Third party cookies must be enabled in your browser for this to work

2. Back on `frontend` under https://m.thegulocal.com set a cookie with the name `GU_U` with any value on the `m.thegulocal.com` domain and refresh the page
3. You should now be signed in!

- You should see the header change to show `My Account` instead of `Sign in`
- In local storage you should see a key `gu.access_token` and `gu.id_token` with the values of the tokens you are signed in with
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"@guardian/commercial": "25.0.0",
"@guardian/core-web-vitals": "6.0.0",
"@guardian/eslint-config-typescript": "9.0.1",
"@guardian/identity-auth": "3.0.0",
"@guardian/identity-auth-frontend": "6.0.3",
"@guardian/identity-auth": "6.0.1",
"@guardian/identity-auth-frontend": "8.1.0",
"@guardian/libs": "20.0.0",
"@guardian/prettier": "^8.0.1",
"@guardian/shimport": "^1.0.2",
Expand Down
26 changes: 13 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3756,8 +3756,8 @@ __metadata:
"@guardian/commercial": "npm:25.0.0"
"@guardian/core-web-vitals": "npm:6.0.0"
"@guardian/eslint-config-typescript": "npm:9.0.1"
"@guardian/identity-auth": "npm:3.0.0"
"@guardian/identity-auth-frontend": "npm:6.0.3"
"@guardian/identity-auth": "npm:6.0.1"
"@guardian/identity-auth-frontend": "npm:8.1.0"
"@guardian/libs": "npm:20.0.0"
"@guardian/prettier": "npm:^8.0.1"
"@guardian/shimport": "npm:^1.0.2"
Expand Down Expand Up @@ -3885,32 +3885,32 @@ __metadata:
languageName: unknown
linkType: soft

"@guardian/identity-auth-frontend@npm:6.0.3":
version: 6.0.3
resolution: "@guardian/identity-auth-frontend@npm:6.0.3"
"@guardian/identity-auth-frontend@npm:8.1.0":
version: 8.1.0
resolution: "@guardian/identity-auth-frontend@npm:8.1.0"
peerDependencies:
"@guardian/identity-auth": ^4.0.1
"@guardian/libs": ^19.0.0
"@guardian/identity-auth": ^6.0.0
"@guardian/libs": ^21.0.0
tslib: ^2.6.2
typescript: ~5.5.2
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/cf39465b55f07dd02a99cbdf10937f0a74797042430b9a50d1259c0f655e272aa1d6a086efece26ace22cde4fa45aab502c16fb155a125f08419b7756084cb1d
checksum: 10c0/905dbe1bb547de79dba6a9a4462f31a9e804d71c7fedbbc87d557f6c7b4fcb20cafc63021f9b0cd254e4718f87f03c4d0cd529b872d62f548eb4ab1558913168
languageName: node
linkType: hard

"@guardian/identity-auth@npm:3.0.0":
version: 3.0.0
resolution: "@guardian/identity-auth@npm:3.0.0"
"@guardian/identity-auth@npm:6.0.1":
version: 6.0.1
resolution: "@guardian/identity-auth@npm:6.0.1"
peerDependencies:
"@guardian/libs": ^18.0.0
"@guardian/libs": ^21.0.0
tslib: ^2.6.2
typescript: ~5.5.2
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/3523c2bb51bcf27bbed548f421d046486465166d2bfda8ea4bdf2bc3de643284b66db981f3512a55cd1f5e04cb6852d44c4b085ff0c7cd21ee5756496150d514
checksum: 10c0/c97408cc262ae3fe4cc8421e3bde26e81455047497618d607a636f64ea45578bda2685f4b503bdd1a383bc55422873b087009c84ced4fd7c9f5d9ed113c3b545
languageName: node
linkType: hard

Expand Down
Loading