Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metadata's description for prettier printing #2185

Merged
merged 9 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/GRPCCore/Metadata.swift
Original file line number Diff line number Diff line change
Expand Up @@ -494,15 +494,15 @@ extension Metadata.Value: ExpressibleByArrayLiteral {

extension Metadata: CustomStringConvertible {
public var description: String {
String(describing: self.map({ ($0.key, $0.value) }))
String(describing: self.map({ ($0.key.description, $0.value.description) }))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to verify the description is as we'd expect for a single Metadata.Value and for a Metadata?

}
}

extension Metadata.Value: CustomStringConvertible {
public var description: String {
switch self {
case .string(let stringValue):
return String(describing: stringValue)
return stringValue
case .binary(let binaryValue):
return String(describing: binaryValue)
}
Expand Down
Loading