Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #4819 #5303

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Revert #4819 #5303

merged 1 commit into from
Mar 3, 2025

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Mar 3, 2025

This reverts commit 830ba27. Unfortunately this suffered from a bug that could cause a panic. Revert until we can reintroduce it without the bug.

See etcd-io/etcd#19509 for more info.

@johanbrandhorst
Copy link
Collaborator Author

I think the problem is that there is no synchronization between returning from the handler and using the http.ResponseWriter in the goroutine that's created to handle the errors. We can reintroduce this if we add a channel or something to synchronize exiting from the goroutine with exiting from the handler.

CC @ianbbqzy

…al streaming (#4795) (#4819)"

This reverts commit 830ba27.
Unfortunately this suffered from a bug that could cause
a panic. Revert until we can reintroduce it without the
bug.
@johanbrandhorst johanbrandhorst enabled auto-merge (squash) March 3, 2025 22:09
@johanbrandhorst johanbrandhorst merged commit 260ccbd into main Mar 3, 2025
14 checks passed
@johanbrandhorst johanbrandhorst deleted the revert-4819 branch March 3, 2025 22:13
@ahrtr
Copy link

ahrtr commented Mar 4, 2025

Thanks for the quick fix and release of v2.26.2!!! @johanbrandhorst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants