Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #5244
Have you read the Contributing Guidelines?
Yes.
Brief description of what is fixed or changed
The
waitForGateway
method waited 10 seconds in a loop forhealthzServer
to return StatusOK.The
healthzServer
function returns StatusOK only ifconn.GetState()
isconnectivity.Ready
- but that never happened because connection stays idle before the first method call.To resolve this, if we detect that the connection is idle, we call any method (in this case, we chose
"/grpc.health.v1.Health/Check"
as it seemed like an appropriate name) and ignore its result, just to get the connection started.This fixes the test startup delay.
Other comments