fix(messageStream): remove call to destroy grpc stream #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
the
do not merge
googlebot
added
the
cla: yes
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
removed
the
do not merge
callmehiphop
requested review from
JustinBeckwith,
alexander-fenster and
stephenplusplus
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 94.85% 94.83% -0.03%
==========================================
Files 15 15
Lines 991 987 -4
Branches 83 83
==========================================
- Hits 940 936 -4
Misses 43 43
Partials 8 8
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Feb 27, 2019
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to grpc/grpc-node#752