Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of typescript module from typescript worker #413

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

justinfagnani
Copy link
Collaborator

This moves the entrypoint of the typescript worker to the same relative location in the src/ tree that it is in the final output, so that any relative external paths in the output bundle point the the right place.

This fixes a problem where imports of ../internal/typescript.js were marked as external, and left in the worker bundle, but the bundle was output to one directory above where the entrypoint was in the source tree, meaning that import should be ./internal/typescript.js and the ../internal/typescript.js import was broken.

In order to have both a rollup input and rollup output at the same level, I needed to rename the input to add an -entrypoint suffix.

@justinfagnani justinfagnani merged commit 3f89dc6 into google:main Aug 20, 2024
4 checks passed
@justinfagnani justinfagnani deleted the fix-ts-import branch August 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants