Use property descriptor impl for java properties #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a java class implements a kotlin interface that declared a property, the descriptor could resolve to a PsiMethod for which we don't have a property implementation (because there is another matching method so single method is not enough). For those cases, fall back to the descriptor implementation. Test: allFunctions.kt Fixes: google#216
ting-yuan
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a java class implements a kotlin interface that declared a property,
the descriptor could resolve to a PsiMethod for which we don't have a
property implementation (because there is another matching method so single
method is not enough). For those cases, fall back to the descriptor implementation.
Test: allFunctions.kt
Fixes: #216