Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nullable marker on KSValueParameter.type, add logic to retriev… #145

Merged
merged 1 commit into from
Nov 6, 2020
Merged

remove nullable marker on KSValueParameter.type, add logic to retriev… #145

merged 1 commit into from
Nov 6, 2020

Conversation

neetopia
Copy link
Contributor

@neetopia neetopia commented Nov 6, 2020

…e type information from property for property setters' value parameter

@neetopia neetopia requested a review from ting-yuan November 6, 2020 02:25
ting-yuan
ting-yuan approved these changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@ting-yuan ting-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging, can you add a test case for inferred type? For example,

var x
   get() = 1
   set(v) = Unit

@neetopia
remove nullable marker on KSValueParameter.type, add logic to retriev…
bbdee4d 
…e type information from property for property setters' value parameter
@neetopia neetopia merged commit 879677f into google:master Nov 6, 2020
@neetopia neetopia deleted the setter-type branch November 6, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ting-yuan ting-yuan ting-yuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neetopia @ting-yuan