Check for type hierarchy while checking overrides #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neetopia
reviewed
Oct 12, 2020
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
Outdated
Show resolved
Hide resolved
| val typeOverride = subClassDescription.getAllSuperClassifiers() | ||
| .filter { it != subClassDescription } // exclude subclass itself as it cannot override its own methods | ||
| .any { | ||
| it == superClassDescription |
There was a problem hiding this comment.
Can these 2 lamdas be merged into one?
There was a problem hiding this comment.
Sequence<ClassifierDescriptor> returns a sequence so i kept them separate for readability (and does not have the cost of creating intermediate lists).
happy to change if you have a strong preference.
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processor/CheckOverrideProcessor.kt
Show resolved
Hide resolved
neetopia
approved these changes
Oct 12, 2020
|
LGTM. Can you rebase commit history a little bit or would you like me to squash them all into one? |
neetopia
reviewed
Oct 12, 2020
compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
Outdated
Show resolved
Hide resolved
There was a bug in overrides check where superClass.foo overrides subClass.foo would return true even though super class cannot override a subClass. This PR fixes that issue by checking for class hiearchy in addition to the method signature. Fixes: google#123 Test: CheckOverrideProcessor
yigit
force-pushed
the
override-from-sub-class
branch
from
f17f13b to
b9ceceb
Compare
|
ready for merge. rebased manually with a proper single commit message. |
|
Merged into master, thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where override would return
trueif base method is sent as the overrider.Similarly, it was also returning true when override is called with the same function itself.
I've also changed the override util call to also check for return type.
Fixes: #123